Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dom binding #27

Open
eddiemonge opened this issue Sep 12, 2014 · 1 comment
Open

Dom binding #27

eddiemonge opened this issue Sep 12, 2014 · 1 comment

Comments

@eddiemonge
Copy link
Contributor

It looks like a click handler is attached to the dom regardless if there is an active dropdown: https://github.com/jseppi/angular-dropdowns/blob/v0.3.0/angular-dropdowns.js#L184

Maybe you should do the bind in the register method and in the unregister, check to see if the dropdown array is empty and if it is, remove the binding.

@elliottregan
Copy link
Contributor

This could be an improvement to my pull request: #34

That might solve the issue of touch events not registering outside of the element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants