Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add !default to $max-height in popup.scss #1142

Open
davidrojo opened this issue Mar 23, 2023 · 0 comments
Open

Add !default to $max-height in popup.scss #1142

davidrojo opened this issue Mar 23, 2023 · 0 comments

Comments

@davidrojo
Copy link

In popup.scss, the variable $max-height doesn't have the !default, which prevents it to be overwrited via custom variables.

So without the !default i cannot do this:

@use "~react-widgets/scss/styles.scss" with (
  $widget-border-radius: $input-border-radius,
  $widget-border-color: $input-border-color,
  $widget-focus-box-shadow: $input-focus-box-shadow,
  $max-height: 400px
);

As I get the following error:

Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: This variable was not declared with !default in the @used module.
  ╷
5 │   $max-height: 400px
  │   ^^^^^^^^^^^^^^^^^^
  ╵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant