Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split date adapters into sub packages to help with peerDependencies r… #4519

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mark-tate
Copy link
Contributor

…esolution

- import { AdapterDateFns } from "@salt-ds/date-adapters";
- import { AdapterDayjs } from "@salt-ds/date-adapters";
- import { AdapterLuxon } from "@salt-ds/date-adapters";
- import { AdapterMoment } from "@salt-ds/date-adapters";
+ import { AdapterDateFns } from "@salt-ds/date-adapters/date-fns";
+ import { AdapterDayjs } from "@salt-ds/date-adapters/dayjs";
+ import { AdapterLuxon } from "@salt-ds/date-adapters/luxon";
+ import { AdapterMoment } from "@salt-ds/date-adapters/moment";

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 8:27pm

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: b8f42e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@salt-ds/date-adapters Patch
@salt-ds/lab Patch
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mark-tate
Copy link
Contributor Author

  • this version does not have repeated lib, sub-directories inside dist
  • it compiles without issue
  • tests work
  • storybook works
  • reworked scripts, although very similar to the Zhihao's version
  • re-use the root script makeTypings, rather than create our own

@mark-tate
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @mark-tate! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@mark-tate
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @mark-tate! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@mark-tate
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @mark-tate! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@mark-tate
Copy link
Contributor Author

@mark-tate
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @mark-tate! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

…esolution

```diff
- import { AdapterDateFns } from "@salt-ds/date-adapters";
- import { AdapterDayjs } from "@salt-ds/date-adapters";
- import { AdapterLuxon } from "@salt-ds/date-adapters";
- import { AdapterMoment } from "@salt-ds/date-adapters";
+ import { AdapterDateFns } from "@salt-ds/date-adapters/date-fns";
+ import { AdapterDayjs } from "@salt-ds/date-adapters/dayjs";
+ import { AdapterLuxon } from "@salt-ds/date-adapters/luxon";
+ import { AdapterMoment } from "@salt-ds/date-adapters/moment";
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant