Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'nested instance' for swaps within Salt DS Component and Patterns library #4517

Open
pseys opened this issue Dec 23, 2024 · 1 comment

Comments

@pseys
Copy link
Contributor

pseys commented Dec 23, 2024

Currently, in components such as Card, where the content area can be toggled on/off to hide or show the 'swap' component we also provide a 'content area' nested instance. In addition the content area toggle the nested instance provides a Swap/Blank option.

Both mechanisms result in the same outcome so are duplicative.

Remove the nested instance wherever Content area is included within the Salt DS components.

@pseys
Copy link
Contributor Author

pseys commented Dec 23, 2024

@yunjungyeh I raised this issue with Ben who asked me to log it as an issue in GH for you to address at some point. It may be a good idea to do this before the new libraries are released to include as a minor enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants