324 replace prism js with shiki #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd03fec The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5190516555
💛 - Coveralls |
mark-tate
reviewed
Jun 7, 2023
| @@ -35,8 +35,7 @@ | |||
| "@jpmorganchase/mosaic-content-editor-plugin": "0.1.0-beta.34", | |||
| "@jpmorganchase/mosaic-site-components": "0.1.0-beta.34", | |||
| "@jpmorganchase/mosaic-layouts": "0.1.0-beta.34", | |||
| "@jpmorganchase/mosaic-theme": "0.1.0-beta.34", | |||
| "prismjs": "^1.23.0" | |||
| "@jpmorganchase/mosaic-theme": "0.1.0-beta.34" | |||
There was a problem hiding this comment.
does this not export Prism CSS from index.js
import 'prismjs/themes/prism.css';
There was a problem hiding this comment.
preset styles did...been removed https://github.com/jpmorganchase/mosaic/pull/375/files#diff-689daf31a0e205fe397769cedbdb31a32f0c9d42088fed8c77d25457e3591c5a
DavieReid
force-pushed
the
324-replace-prism-js-with-shiki
branch
from
3903f60 to
4546369
Compare
DavieReid
force-pushed
the
324-replace-prism-js-with-shiki
branch
from
e62640e to
9085256
Compare
DavieReid
force-pushed
the
324-replace-prism-js-with-shiki
branch
from
9085256 to
000052b
Compare
DavieReid
force-pushed
the
324-replace-prism-js-with-shiki
branch
from
000052b to
fd03fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.