Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update passport-oauth to ^1.0.0 #7

Open
analog-nico opened this issue Nov 9, 2015 · 3 comments
Open

Update passport-oauth to ^1.0.0 #7

analog-nico opened this issue Nov 9, 2015 · 3 comments

Comments

@analog-nico
Copy link

Unless this library upgrades to passport-oauth ^1.0.0 it will crash req.logIn(...) when the app is using the latest version of Passport. This is caused by introducing lazy session initialization in passport 0.3.0. See the technical details and Jared's explanation.

Let me know if I can help.
@analog-nico analog-nico changed the title Critical: Update passport-oauth to ^1.0.0 Update passport-oauth to ^1.0.0 Nov 9, 2015
@analog-nico
Copy link
Author

FYI, [email protected] just got released which applies a general patch. So I removed the "Critical" in the title.

@jozzhart
Copy link
Owner

I'm happy to take pull requests, or add maintainers, as I haven't used this for years

@analog-nico
Copy link
Author

Unfortunately, I don't use your library and thus couldn't test the update. (I am just the messenger. ;) Maybe we just keep this issue open for another user of this library to jump in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jozzhart @analog-nico