Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove hatch from deps #54

Open
trim21 opened this issue Jun 9, 2024 · 1 comment · May be fixed by #61
Open

chore: remove hatch from deps #54

trim21 opened this issue Jun 9, 2024 · 1 comment · May be fixed by #61
Labels
enhancement New feature or request

Comments

@trim21
Copy link

trim21 commented Jun 9, 2024

looks like it only need hatch here

hatch-cython/src/hatch_cython/config/config.py

Line 7 in 0488f78

from hatch.utils.ci import running_in_ci

it's a 2 lines function

def running_in_ci() -> bool:
    return any(os.environ.get(env_var) in {'true', '1'} for env_var in ('CI', 'GITHUB_ACTIONS'))

can we just copy this file into this project so we don't need to install hatch when building? it could speedup build
@joshua-auchincloss
Copy link
Owner

@trim21 sure, I'm happy with that change! Will work into v0.6.0rc2

@joshua-auchincloss joshua-auchincloss changed the title remove hatch from deps? chore: remove hatch from deps Jun 9, 2024
@joshua-auchincloss joshua-auchincloss added the enhancement New feature or request label Jun 9, 2024
@trim21 trim21 linked a pull request Oct 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove hatch from deps to speedup building trim21/hatch-cython
2 participants
@trim21 @joshua-auchincloss