Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV shows are missing from Maintainerr when they are monitored but have no files #892

Open
jberlyn opened this issue Feb 11, 2024 · 10 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jberlyn
Copy link

jberlyn commented Feb 11, 2024

I currently have a rule setup that will automatically delete and unmonitor a season of a TV show if no one watches any episodes from that season for 90 days. This functionality works perfectly, no issues there.

However, in my circumstance, TV shows can get into a state where they are monitored in Sonarr, but none of the seasons are monitored and there are no files (because my previous rule has deleted and unmonitored the seasons).

If the show is a continuing show, it's not a problem because chances are my users will want to watch future seasons, so keeping it within Sonarr is useful because it'll grab those new episodes when they are available.

The issue I am running into is when shows have finished and have an Ended state in Sonarr. This leaves the show itself monitored in Sonarr, no seasons monitored, no episodes downloaded and no future episodes coming. In this case, I'd like to just have a rule that would delete the entire show from Sonarr since my users don't care about the show any more.

This seems pretty straight forward, however I noticed that shows that don't exist in Plex (which in my circumstance they won't any more, because the files are deleted) aren't interactable in the Maintainerr overview, or via Maintainerr rules/collections.

I have tried the following rules and none of them pickup the shows in that state:

mediaType: SHOWS
rules:
  - "0":
      - firstValue: Sonarr.ended
        action: EQUALS
        customValue:
          type: boolean
          value: "true"
      - operator: AND
        firstValue: Plex.sw_episodes
        action: EQUALS
        customValue:
          type: number
          value: 0
mediaType: SHOWS
rules:
  - "0":
      - firstValue: Sonarr.ended
        action: EQUALS
        customValue:
          type: boolean
          value: "true"
      - operator: AND
        firstValue: Sonarr.diskSizeEntireShow
        action: EQUALS
        customValue:
          type: number
          value: 0

Here are some screenshots the show's state in Sonarr.

image
image

image
image

I am running Maintainerr on Docker, and my current version is v2.0.1.

@jorenn92
Copy link
Owner

Hey! I noticed your discussion in Discord a bit late, so I appreciate you bringing it up as an issue. That way, I don't have to read through the entire message history 😅.

Maintainerr is designed to fetch Plex's library data initially, so it doesn't recognize your monitored *arr items without data.
Changing this would be a significant alteration, potentially leading to unintended side effects.

Perhaps another solution could be adding a checkbox on the rule page. This checkbox would allow users to force-remove ended shows, even when the action is set to 'unmonitor'. What do you think?

@jberlyn
Copy link
Author

jberlyn commented Feb 11, 2024

Perhaps another solution could be adding a checkbox on the rule page. This checkbox would allow users to force-remove ended shows, even when the action is set to 'unmonitor'. What do you think?

That could work. How would you envision the rule setup to be for my current scenario?

This is the rule set I have setup right now that tackles TV shows. The media type is set to Seasons and the Sonarr Action is set to Unmonitor and delete season.

mediaType: SEASONS
rules:
  - "0":
      - firstValue: Plex.addDate
        action: BEFORE
        customValue:
          type: custom_days
          value: "60"
      - operator: AND
        firstValue: Plex.sw_amountOfViews
        action: EQUALS
        customValue:
          type: number
          value: 0
      - operator: AND
        firstValue: Sonarr.tags
        action: NOT_CONTAINS
        customValue:
          type: text
          value: maintainerr-immunity
  - "1":
      - operator: OR
        firstValue: Plex.lastViewedAt
        action: BEFORE
        customValue:
          type: custom_days
          value: "60"
      - operator: AND
        firstValue: Sonarr.tags
        action: NOT_CONTAINS
        customValue:
          type: text
          value: maintainerr-immunity

@jberlyn
Copy link
Author

jberlyn commented May 23, 2024

@jorenn92 Sorry to ping you, just wondering if there was any update on this one? Was there anything else I can help with from a testing side?

@jorenn92
Copy link
Owner

@jberlyn, sorry for the delay; I've been busy and haven't had time to implement this yet. I'm also not entirely happy with the solution I proposed earlier. I'm still figuring out the best approach to tackle this. But I'm always open to ideas and suggestion!

@jberlyn
Copy link
Author

jberlyn commented May 29, 2024

@jberlyn, sorry for the delay; I've been busy and haven't had time to implement this yet. I'm also not entirely happy with the solution I proposed earlier. I'm still figuring out the best approach to tackle this. But I'm always open to ideas and suggestion!

I think your initial solution with just an option to "Remove entire show if Ended and no other seasons exist on disk" would work.

Copy link
Contributor

This issue has been marked stale because it has been 30 days with no activity.

@github-actions github-actions bot added the stale When something hasn't had any activity in a while. label Oct 19, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot added the stale-closed Something that was closed automatically because it was stale. label Nov 3, 2024
@github-actions github-actions bot closed this as completed Nov 3, 2024
@jberlyn
Copy link
Author

jberlyn commented Nov 6, 2024

Not stale, I am still needing to manually remove items from Sonarr.

@ydkmlt84 ydkmlt84 added bug Something isn't working enhancement New feature or request and removed stale When something hasn't had any activity in a while. stale-closed Something that was closed automatically because it was stale. labels Nov 7, 2024
@ydkmlt84
Copy link
Collaborator

ydkmlt84 commented Nov 7, 2024

Not stale, I am still needing to manually remove items from Sonarr.

Thank you for bringing it back up. I have changed the labels so that it won't get auto closed again. We will add this to our plate and see what solution we can come up with. I believe something similar to what was discussed could be the solution, we just need to figure out the best way to implement it.

Thanks again!

@ydkmlt84 ydkmlt84 reopened this Nov 7, 2024
@bitnimble
Copy link

bitnimble commented Dec 4, 2024

Hey there, I'm a recent new user of Maintainerr and came across a similar issue that I think falls under a similar/same solution here.

Wondering if a checkbox along the lines of "Delete show when last season is deleted" would work? And that checkbox would only be displayed for the "Seasons" media type.

I'm a developer and I'm happy to raise a PR for this if that seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants