Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Versions option #13

Open
shoulders opened this issue Nov 10, 2019 · 3 comments
Open

Enable Versions option #13

shoulders opened this issue Nov 10, 2019 · 3 comments
Assignees

Comments

@shoulders
Copy link

This is disabled by default. I think it should be enabled by default.

@chetanmadaan
Copy link
Member

There is a issue with enabling it by default, that is. It'll fill up your table really quickly.

Let's imagine a simple page with a couple of sections and elements in them, the JSON can easily get around 400 - 500 kb, that's 0.5 MB per revision and quick 20 revisions away, you are looking at a table size of 10 MB and that's just for one page.

So, if the user knows the above and decides to enable revisions, I think that would be a better thing.

@shoulders
Copy link
Author

I know you have closed this issue, but how will the end user know they can enable revisions.

@chetanmadaan chetanmadaan reopened this Nov 12, 2019
@chetanmadaan
Copy link
Member

  1. I have reopened it now.
  2. I'll put together documentation on the versioning and then close it back :).

@chetanmadaan chetanmadaan self-assigned this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants