feat: A way to warn user on default variable usage #454
Conversation
|
Your PR was set to target |
| @@ -391,6 +394,8 @@ def get_value(self, var, cast=None, default=NOTSET, parse_default=False): | |||
| raise ImproperlyConfigured(error_msg) from exc | |||
|
|
|||
| value = default | |||
| if self._WARN_ON_DEFAULT_VALUE_USAGE: | |||
| logger.warn(f"Variable '{var}' is using a default variable.") | |||
There was a problem hiding this comment.
Here is a tutorial-style HOWTO taking you through the steps in using the logging module. https://docs.python.org/3/howto/logging.html
warnings.warn()in library code if the issue is avoidable and the client application should be modified to eliminate the warning
logging.warning()if there is nothing the client application can do about the situation, but the event should still be noted
Considering the above, do you still think that the logging is the better solution here?
There was a problem hiding this comment.
Thinking about it again, I have to agree with you. the pythonic warning package is a better substitute for this case.
There was a problem hiding this comment.
Could you please made the necessary changes?
sergeyklay
added
enhancement
This PR added a way to warn users of any variable that is using their default values.