Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Env.read_env()'s "overrides" argument actually override variables #136

Closed
wants to merge 3 commits into from

Conversation

fdemmer
Copy link
Contributor

@fdemmer fdemmer commented Jun 29, 2017

Proposed fix and clarification in docstring for #103. As mentioned in the issue I am not 100% clear on what the intention with overrides was, but as it is called "override" I thought it maybe should override variables ;)

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage remained the same at 88.312% when pulling ee62426 on fdemmer:103-read_env-overrides into 7e50e34 on joke2k:develop.

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage increased (+3.8%) to 89.51% when pulling 31fd174 on fdemmer:103-read_env-overrides into c262002 on joke2k:develop.

@QasimK
Copy link

QasimK commented Mar 29, 2018

There is a bit of history with regards to variable precedence: e.g. #58 #66 #88. This may be a backwards-incompatible change :(

@joke2k joke2k added the wontfix This will not be worked on label Jun 5, 2018
@joke2k joke2k closed this Jun 5, 2018
@joke2k joke2k modified the milestone: Road to 0.4.5 Jun 5, 2018
@joke2k joke2k reopened this Jun 5, 2018
@joke2k joke2k added bug Something isn't working and removed wontfix This will not be worked on labels Jun 5, 2018
@joke2k joke2k added this to the Road to 0.4.5 milestone Jun 5, 2018
@sergeyklay
Copy link
Collaborator

PR was closed by mistake. Reopened it.

@sergeyklay
Copy link
Collaborator

This is implemented in develop branch. Thank you for the pathc, and for helping us make django-environ better. And I am sorry about the delay.

@sergeyklay sergeyklay closed this Sep 27, 2021
@sergeyklay sergeyklay self-assigned this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants