Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DicomDifferenceLogger leaves large amount of temp files #14

Open
seandoyle opened this issue Dec 7, 2016 · 5 comments
Open

DicomDifferenceLogger leaves large amount of temp files #14

seandoyle opened this issue Dec 7, 2016 · 5 comments

Comments

@seandoyle
Copy link

Hi -

I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:

$ git diff ctp/stdstages/DicomDifferenceLogger.java
diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java
index 23f31d7..7cb3325 100644
--- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java
+++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java
@@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo
if (quarantine != null) quarantine.insertCopy(fileObject);
logger.warn(name+": Unable to enter difference object in the export queue");
}
+ logger.debug(name+": about to delete file " + entryFile.getAbsolutePath());
+ entryFile.delete();
}
This seems to work well for me - but if it's a bad fix please let me know.

@johnperry
Copy link
Owner

johnperry commented Dec 7, 2016 via email

@seandoyle
Copy link
Author

seandoyle commented Dec 8, 2016 via email

@johnperry
Copy link
Owner

johnperry commented Dec 8, 2016 via email

@seandoyle
Copy link
Author

seandoyle commented Dec 8, 2016 via email

@johnperry
Copy link
Owner

johnperry commented Dec 8, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants