Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #3

Open
johnomotani opened this issue Feb 3, 2021 · 0 comments
Open

Refactoring #3

johnomotani opened this issue Feb 3, 2021 · 0 comments

Comments

@johnomotani
Copy link
Owner

Some things that would be nice to do to make this package easier to work with in other codes:

  • Merge CerfonFreidberg and CerfonFreidbergSymmetric into a single class, just have a setting to switch between the different solutions.
  • Instead of setting up the solution with arguments to .init() method, define the settings using OptionsFactory (see for example the use of OptionsFactory in hypnotoad), and replace the init() methods with a constructor __init__(self, settings) that takes a dict that is passed to the OptionsFactory instance (and could be loaded from a YAML file, etc.).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant