Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add async api #461

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add async api #461

wants to merge 4 commits into from
+203 −3

Conversation

th4s
Copy link

@th4s th4s commented Sep 6, 2024 •
edited by johanhelsing
Loading

This PR adds an async api:

  • implement Sink and Stream for WebRtcChannel
  • add type RawPeerChannel with AsyncRead and AsyncWrite support
  • add functions take_raw and take_raw_by_id on WebRtcSocket

Closes: #453

@th4s th4s changed the title Add async api feat: add async api Sep 6, 2024
@Craig-Macomber Craig-Macomber mentioned this pull request Oct 18, 2024
Open
johanhelsing
johanhelsing approved these changes Dec 12, 2024
View reviewed changes
Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really useful. And like you say, an easy win.

Sorry for the slow response. We are most likely removing the typestate pattern from the matchbox socket so might need an update if #468 gets in first.

@johanhelsing
Copy link
Owner

#468 is in. If you fix the conflicts, we'll get this in in time for the 0.11 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanhelsing johanhelsing johanhelsing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AsyncWrite and AsyncRead for WebRtcChannel
2 participants
@th4s @johanhelsing