Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression: "Thrown during type checking", "System.NullReferenceException" #90

Open
FelesNoctis opened this issue Sep 8, 2019 · 5 comments
Assignees
Labels
bug Something isn't working language service

Comments

@FelesNoctis
Copy link

FelesNoctis commented Sep 8, 2019

Describe the bug
Error log found here: https://pastebin.com/y81gSVYP
When the extension is attempting to read and process an expression, any time the expression is incomplete it will throw this error. It appears to "jump the gun", trying to evaluate/cast empty space.

To Reproduce
Steps to reproduce the behavior:

  1. Create an expression.
    debug.Notification("Old Value: ")
  2. Edit the expression with additional information.
    debug.Notification("Old Value: " +)
  3. Error appears at this point while typing.
@FelesNoctis FelesNoctis added the bug Something isn't working label Sep 8, 2019
@minkir014
Copy link

minkir014 commented Sep 9, 2019

I think this is ideal. This happens to all languages for me. When you leave a plus sign without something after it, it gives an error but the error disappears when I complete something after it.

@FelesNoctis
Copy link
Author

FelesNoctis commented Sep 9, 2019

What languages are you looking at? Generally it would be the job of a linter to report an error in the code, not an error breaking the extension itself.

For instance, the same expression error in Javascript:

Papyrus-Lang already has a linter, the error should be properly funneling its output there similar to everything else.

@minkir014
Copy link

I didn't know it breaks the extension itself.

@FelesNoctis
Copy link
Author

Yeah. The error in question is due to the extension not properly handling the circumstance in question. The VSCode error log was posted to pastebin and linked above.

@joelday
Copy link
Owner

joelday commented Sep 27, 2023

This will be addressed in the rewrite in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language service
Projects
None yet
Development

No branches or pull requests

3 participants