Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wonky syntax highlighting when escaping delim-pair characters or inputting some contextually non-delim-pair characters in strings. #165

Open
NidusUmbra opened this issue Dec 31, 2022 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers grammar TextMate grammar/language configuration help wanted Extra attention is needed

Comments

@NidusUmbra
Copy link

NidusUmbra commented Dec 31, 2022

Describe the bug
Syntax highlighting displays the wrong colors when escaping some characters that require it, in strings and also when not closing delim-pairs in a context where that isn't necessary for syntax compliance. Compiling and running the code works just fine, it's only the coloring. It becomes confusing and the colors-errors cascade downward as well until pairs are 'closed' inside a comment (not always feasible).

To Reproduce
Escape a " (i.e. "\"") and succeeding text becomes orange (or whatever the theme has set for strings). Put a { in a string ("{") and the same happens except in block-comment-color. ";" does not have this problem. Now compile.

  1. ...
    2022-12-31 10 53 40
@NidusUmbra NidusUmbra added the bug Something isn't working label Dec 31, 2022
@joelday
Copy link
Owner

joelday commented Jan 11, 2023

@NidusUmbra Does this repro on a pre-3.0.0 version of the extension? I haven't had some time to try that out yet.

@NidusUmbra
Copy link
Author

NidusUmbra commented Jan 20, 2023

@joelday

I tried it on v2.23.12 and it looks pretty much identical. (Included a related highlighting issue in the function header pertaining to backslash-escape.)
2023-01-20 17 04 57

@joelday
Copy link
Owner

joelday commented Jan 20, 2023

K, I just wanted to rule out a recent change to the syntax highlighter grammar that didn't wind up in the 3.0.1 changelog.

@joelday joelday added help wanted Extra attention is needed good first issue Good for newcomers grammar TextMate grammar/language configuration labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers grammar TextMate grammar/language configuration help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants