Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: default swap-storage to false #12

Open
zaikunzhang opened this issue Sep 10, 2023 · 0 comments
Open

Suggestion: default swap-storage to false #12

zaikunzhang opened this issue Sep 10, 2023 · 0 comments

Comments

@zaikunzhang
Copy link

zaikunzhang commented Sep 10, 2023

Hello @jlumbroso ,

First of all, thank you for this fantastic action. It is vital in the development of my project PRIMA.

README mentions the following.

        # all of these default to true, but feel free to set to
        # "false" if necessary for your workflow
        android: true
        dotnet: true
        haskell: true
        large-packages: true
        docker-images: true
        swap-storage: true

I suggest defaulting swap-storage: true to false. Otherwise, some memory-consuming actions may get the runner shut down due to memory starvation --- it is not uncommon for a space-intensive action to be memory-hungry as well. This did happen in PRIMA, and it took a couple of days to figure out that swap-storage: true was the reason.

If swap-storage: true is going to be retained, then careful documentation may be necessary to highlight the above-mentioned caveat.

Many thanks!

Best regards,
Zaikun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant