Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delta magnitude technicality #39

Open
caseylam opened this issue Jul 6, 2022 · 0 comments
Open

delta magnitude technicality #39

caseylam opened this issue Jul 6, 2022 · 0 comments

Comments

@caseylam
Copy link
Collaborator

caseylam commented Jul 6, 2022

I just realized while writing up some documentation, that there is something technically not right in PopSyCLE for the delta magnitude.
The amplification is calculated using A = (u^2 + 2)/(u * sqrt(u^2 + 4)), with u = u0.
But u0 is the closest approach in the heliocentric rectilinear frame, not the observed geocentric accelerating frame.
So if you were an earthly observer (which, since we report piE's, seems logical), the calculated A will differ from the true maximum A.
However, to get this right, we'd need to put in ephemerides into PopSyCLE, and also assign some type of absolute scale to t0 (which is completely arbitrary right now).
I don't think we actually want to do that. So this "bug" doesn't necessarily requires any direct action/fixing, but just something to keep in mind.

Side question: I wonder if averages out between extra magnification and demagnification, so the delta mag is still right on average.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant