Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduledFireTime is not set correctly when trigger fires #68

Open
k1th opened this issue Jul 25, 2022 · 0 comments
Open

scheduledFireTime is not set correctly when trigger fires #68

k1th opened this issue Jul 25, 2022 · 0 comments

Comments

@k1th
Copy link

k1th commented Jul 25, 2022

            TriggerFiredBundle triggerFiredBundle = new TriggerFiredBundle(job, trigger, calendar, false, new Date(), previousFireTime, previousFireTime, trigger.getNextFireTime());

sets scheduledFireTime not to the "real" scheduled time when misfires are processed.
This plays a role when the misfire policy is set to MISFIRE_INSTRUCTION_IGNORE_MISFIRE_POLICY

Fix: Change to

            TriggerFiredBundle triggerFiredBundle = new TriggerFiredBundle(job, trigger, calendar, false, new Date(), trigger.getPreviousFireTime(), previousFireTime, trigger.getNextFireTime());

like the other job stores do.

k1th pushed a commit to k1th/quartz-redis-jobstore that referenced this issue Jul 25, 2022
k1th added a commit to k1th/quartz-redis-jobstore that referenced this issue Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant