Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleTrigger scheduled to execute once is firing indefinite number of times #39

Open
vinitpatni opened this issue Jun 9, 2019 · 1 comment

Comments

@vinitpatni
Copy link

vinitpatni commented Jun 9, 2019

We are scheduling job using simple trigger which is meant to be fired only once in a fixed datetime in future. We are using RedisJobStore to schedule jobs in a clustered mode. Trigger is executing job at scheduled time but after that job is misfiring indefinite number of times. Following are stats of trigger
where startFireTime is set to the time at which job was scheduled to execute.

{
"startFireTime": "Sun Jun 09 15:10:00 IST 2019",
"nextFireTime": "Sun Jun 09 15:11:39 IST 2019",
"previousFireTime": "Sun Jun 09 15:13:50 IST 2019",
"finalFireTime": "Sun Jun 09 15:10:00 IST 2019",
"endFireTime": null

}

here suprisingly nextFireTime is less than previousFireTime. nextFireTime should be set to null after the single execution of job

@SajadBishop
Copy link

SajadBishop commented May 7, 2022

SimpleTrigger uses the timesTriggered property for cancelling the next fire time if it has surpassed the specified repeat count. However, this field is not being updated/persisted in the Redis storage, and this causes the nextFireTime not to be set property and causes a misfire instruction to take place over, causing the job to reschedule. Please fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants