Don't use --timestring when command is snapshot

[abo-adapt]

Currently snapshot cronjobs get --timestring added. This results in curator giving a warning that --timestring is used, but neither --newer-than nor --older-than is used. This prevents the command from actually executing through cron (at least on our servers). This simple patch fixes that:

--- a/modules/curator/manifests/job.pp
+++ b/modules/curator/manifests/job.pp
@@ -81,7 +81,11 @@ define curator::job (
$_regex = undef
}

• $_timestring = "--timestring '${timestring}'"
• if ($command == "snapshot") {
• $_timestring = undef
• } else {
• $_timestring = "--timestring '${timestring}'"
• }

[jlambert121]

What version of curator are you using?

[abo-adapt]

$ curator --version
curator, version 3.3.0

The evenup/curator puppet module is version 2.1.1

[jlambert121]

It looks like my version of curator is a bit dated (3.0.2) which works fine. The timestring parameter is one I use on snapshots so I don't want to just remove it completely. Other thoughts on how to tackle this?