-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid UNTIL value #385
Comments
This is not a bug but an error message. To avoid it just wait with sending the value until you have the full date in your input. |
ahm, excuse me but i think it is a bug, because when i put the year 0010 in it everything works just fine! Everything lower than 0010 does not work and trows an error. I think it should also work even if almost nobody will set this as a date-value. |
so, will there be a fix for this issue? |
@Rockatweb please describe the issue in detail and provide a replicable way of producing the error. Getting an error from an invalid formatted date is not a bug. I will close this issue for now. Please reopen if you can provide details. |
ok ok, i understand. You need more details then the details in the opening post... First of all the date 01.01.0001 is a valid date, at least here in germany. So this string ist correct, because it is the year 0001 AD. So the given string would be the following iso-date 0001-01-01.
If i log the given date-object the value ist this:
But the library throws the error:
because it seems that it calculates the wrong year. If i put the following date into the until-value everything works fine:
So everything until this date does not work in the lib, even this one doesn't work:
I hope it's now more clearly. |
Yes, but your initial post used '10.10.0009, 10:10' which is not a valid date format (using comma). I am unable to replicate 'invalid date'. Make sure you are using ISO8601 formatted date. Please let me know the full date you are trying. Are you also setting DTSTART to a lower value? I do see two issues here:
|
ok, than i am sry, that i provided a wrong date in the initial Post. I just copied it from a date-input. So it is easy to reproduce this behaviour in the demo:
It is the same way i use the library in our project. So what am i doing? https://www.dropbox.com/s/wdx1eliwjgch754/video.mov?dl=0 The issues that you see are "correct".
I hope that you can work with this informations :) |
I also encountered this bug. Here's an example
I think this is due to some strange padding in Line 73 in 9f2061f
As @Rockatweb already said, this happens for all dates smaller than "0010-01-01". Background: Calendar events from Microsoft calendars will have end date of "0001-01-01" if no end date is set... Thanks MS. |
Happened to us as well in production. It's very unfortunate that it's still not fixed after 4 years |
@macmillen pull requests are welcome :) |
Hey @espen I created a PR a while ago. Is there still anything you need from my side? |
great to see your contribution @macmillen. I added some comments. Maybe I am misunderstanding here but the test value seems to be invalid. If so please add a valid DTSTART with a year lower than 10. Also, I am just responding to issues here and not the maintainer. |
Hello,
i found a bug in the lib when you use the UNTIL Value with a year that is smaller than 10. You can comprehend this bug on the demo page if you put the following value in the UNTIL Input:
10.10.0009, 10:10
will generate
RRULE:FREQ=WEEKLY;UNTIL=00,91010T101000Z
And if you want to parse this string with the fromString-function the lib throws the error:
=> Error: Invalid UNTIL value: 00,91010T101000Z
For me this bug is critical, because when you use the date-input and start typing the year, the lib throws this error.
The text was updated successfully, but these errors were encountered: