-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose the best matching pom if multiple are found in the jar file #322
Comments
Ok, it does choose the wrong file, then it downloads a correct one, because it happens that in the wrong file a license is also not present. But the reason why the license is wrong is that if the license is not found in the pom, it keeps resolving parents until it finds one and it goes up to a completely unrelated relicense in https://repo1.maven.org/maven2/org/eclipse/ee4j/project/1.0.9/project-1.0.9.pom which has that |
…y choosing the first one.
I submitted the fix anyway, since if they have multiple pom.xml files, others might as well, and the logic could misfire, but with this fix it will pick the best match. |
Is it a but that it fetches parent poms despite |
It looks like no Gradle-License-Report/src/main/groovy/com/github/jk1/license/reader/PomReader.groovy Line 237 in 8da16c1
It would be nice to be able to turn that off, it is kind of counter intuitive. And contradicts the documentation https://github.com/jk1/Gradle-License-Report?tab=readme-ov-file#configuration
|
…y choosing the first one.
…to allow to disable parent merging completely.
Here is a PR for that as well #324 with these changes, the report is much better. |
For some reason Jaxb has multiple pom.xml files in the jar file. At the moment the plugin chooses the first one, which happens to be an incorrect one, as the result license is not correct as well.
The report says pom license is
GNU General Public License, version 2 with the GNU Classpath Exception - https://www.gnu.org/software/classpath/license.html
when it is actuallyEDL-1.0
.https://github.com/eclipse-ee4j/jaxb-ri/blob/b7d1ff7a13cecfaadde733387216b5cad09cc5b5/jaxb-ri/bundles/core/pom.xml#L29
The text was updated successfully, but these errors were encountered: