You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #301.
As you added the stream-variant, but not the URL variant, there is a problem now.
When I configure the licenseReport extension, I already have to open the stream to give it to the constructor of LicenseBundleNormalizer.
Only when the filter is actually used and thus the init() method is called, the stream is consumed and then closed.
But if you invoke a build that does not run through that code-path, the file handle leaks and you for example cannot switch branches where the file needs to be deleted and similar.
URL would have been better for my use-case here as that would not cause the stream to stay open and so for example cause a file handle leak.
(No, I can not use the String constructor instead, as I get the file from classpath and during test execution of my plugin this just happens to be a file on disk. And even if it were from the Jar, I guess the Jar file handle would then leak)
Maybe it would be better to consume the stream directly in the constructor for example.
Or a way to open the stream only on-demand.
Or the URL variant.
The text was updated successfully, but these errors were encountered:
Follow-up to #301.
As you added the stream-variant, but not the URL variant, there is a problem now.
When I configure the
licenseReport
extension, I already have to open the stream to give it to the constructor ofLicenseBundleNormalizer
.Only when the filter is actually used and thus the
init()
method is called, the stream is consumed and then closed.But if you invoke a build that does not run through that code-path, the file handle leaks and you for example cannot switch branches where the file needs to be deleted and similar.
URL would have been better for my use-case here as that would not cause the stream to stay open and so for example cause a file handle leak.
(No, I can not use the
String
constructor instead, as I get the file from classpath and during test execution of my plugin this just happens to be a file on disk. And even if it were from the Jar, I guess the Jar file handle would then leak)Maybe it would be better to consume the stream directly in the constructor for example.
Or a way to open the stream only on-demand.
Or the URL variant.
The text was updated successfully, but these errors were encountered: