Skip to content
This repository has been archived by the owner on Oct 11, 2018. It is now read-only.

params on php::fpm are not used #81

Open
kitchen opened this issue Jun 21, 2014 · 3 comments
Open

params on php::fpm are not used #81

kitchen opened this issue Jun 21, 2014 · 3 comments

Comments

@kitchen
Copy link

kitchen commented Jun 21, 2014

the php::fpm::package class takes its param defaults directly from php::fpm::params class, and not php::fpm, so the params on php::fpm never get used. I imagine there are more like this, as well.

I'll fix this, but I need an approach. right now you have php::fpm inheriting php::fpm::params and php::fpm::package inheriting nothing. Proposal: php::fpm::package (and config and daemon and such) inherit from php::fpm, which inherits from php::fpm::params. Defaults in the various php::fpm::* classes will come from php::fpm's parameters, and maybe even deprecate the parameters directly on them in favor of top level params on php::fpm

Then I should be able to fairly readily port this module to fedora 20 :)

@jippi
Copy link
Owner

jippi commented Jun 22, 2014

Hi

I've only ever configured the plugin using hiera, so the inheritance may be a bit off :)

If you got the logic for that down, by all means PR a fix - it will be highly appreciated

Also fedora support would be amazing!

@parhamr
Copy link

parhamr commented Aug 19, 2014

+1 I’ve also seen this bug

@jippi
Copy link
Owner

jippi commented Aug 19, 2014

Alright, if you got a PR that can resolve it, it would be highly appreciated

schkovich pushed a commit to schkovich/puppet-php that referenced this issue Aug 22, 2014
schkovich added a commit to schkovich/puppet-php that referenced this issue Aug 23, 2014
Making php::fpm a single installation entry point.
jippi added a commit that referenced this issue Aug 29, 2014
params on php::fpm are not used #81
cegeka-jenkins pushed a commit to cegeka/puppet-php that referenced this issue Mar 21, 2018
By default extension setting keys are now prefixed with "<name>.".
If the prefix is already present, nothing is changed.

This allows for simpler extension configuration by simply passing
the setting name without prefix.

Fixes jippi#81
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants