This repository has been archived by the owner on Oct 11, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
params on php::fpm are not used #81
Comments
Hi I've only ever configured the plugin using hiera, so the inheritance may be a bit off :) If you got the logic for that down, by all means PR a fix - it will be highly appreciated Also fedora support would be amazing! |
+1 I’ve also seen this bug |
Alright, if you got a PR that can resolve it, it would be highly appreciated |
schkovich
pushed a commit
to schkovich/puppet-php
that referenced
this issue
Aug 22, 2014
schkovich
added a commit
to schkovich/puppet-php
that referenced
this issue
Aug 23, 2014
Making php::fpm a single installation entry point.
cegeka-jenkins
pushed a commit
to cegeka/puppet-php
that referenced
this issue
Mar 21, 2018
By default extension setting keys are now prefixed with "<name>.". If the prefix is already present, nothing is changed. This allows for simpler extension configuration by simply passing the setting name without prefix. Fixes jippi#81
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
the
php::fpm::package
class takes its param defaults directly fromphp::fpm::params
class, and notphp::fpm
, so the params onphp::fpm
never get used. I imagine there are more like this, as well.I'll fix this, but I need an approach. right now you have
php::fpm
inheritingphp::fpm::params
andphp::fpm::package
inheriting nothing. Proposal:php::fpm::package
(and config and daemon and such) inherit fromphp::fpm
, which inherits fromphp::fpm::params
. Defaults in the variousphp::fpm::*
classes will come fromphp::fpm
's parameters, and maybe even deprecate the parameters directly on them in favor of top level params onphp::fpm
Then I should be able to fairly readily port this module to fedora 20 :)
The text was updated successfully, but these errors were encountered: