From 02dc09d0f83932e67d5c34d7daaa6691f1646284 Mon Sep 17 00:00:00 2001 From: Juan Ignacio Polanco Date: Wed, 25 Jan 2023 14:54:20 +0100 Subject: [PATCH 1/3] CI: don't precompile in parallel --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 128f8914..e77cbb4f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,6 +12,7 @@ on: env: JULIA_HDF5_PATH: /usr/lib/x86_64-linux-gnu/hdf5/mpich + JULIA_NUM_PRECOMPILE_TASKS: 1 # try to fix precompilation step LD_PRELOAD: /usr/lib/x86_64-linux-gnu/libstdc++.so.6:/usr/lib/x86_64-linux-gnu/libcurl.so.4 # workaround for libhdf5 jobs: From bcf4bb9e82a251af5f6d11cfbf273b2a05944080 Mon Sep 17 00:00:00 2001 From: Juan Ignacio Polanco Date: Wed, 25 Jan 2023 15:54:05 +0100 Subject: [PATCH 2/3] Precompilation: don't set strict = true --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e77cbb4f..0bbabccf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,6 @@ on: env: JULIA_HDF5_PATH: /usr/lib/x86_64-linux-gnu/hdf5/mpich - JULIA_NUM_PRECOMPILE_TASKS: 1 # try to fix precompilation step LD_PRELOAD: /usr/lib/x86_64-linux-gnu/libstdc++.so.6:/usr/lib/x86_64-linux-gnu/libcurl.so.4 # workaround for libhdf5 jobs: @@ -75,7 +74,7 @@ jobs: run: | using Pkg Pkg.instantiate(verbose = true) - Pkg.precompile(strict = true) + Pkg.precompile(strict = false) - uses: julia-actions/julia-runtest@v1 From 318e0b8a566df0303c6afa739a6fa6c1a921d430 Mon Sep 17 00:00:00 2001 From: Juan Ignacio Polanco Date: Tue, 31 Jan 2023 11:07:11 +0100 Subject: [PATCH 3/3] Tests: use Base.splat for compatibility --- test/reductions.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/reductions.jl b/test/reductions.jl index 8fcd4199..8d05e5a8 100644 --- a/test/reductions.jl +++ b/test/reductions.jl @@ -1,7 +1,6 @@ using MPI using PencilArrays using Test -using Compat: Splat MPI.Init() @@ -30,7 +29,7 @@ fill!(u, 2myid) a = @inferred sum(abs2, û; init = zero(eltype(û))) # `init` needed for inference when eltype(û) = Complex{Int32}... # These should all be equivalent: b = @inferred mapreduce((x, y) -> real(x * conj(y)), +, û, v̂) - c = @inferred sum(Splat((x, y) -> real(x * conj(y))), zip(û, v̂)) + c = @inferred sum(Base.splat((x, y) -> real(x * conj(y))), zip(û, v̂)) d = @inferred sum(xs -> real(xs[1] * conj(xs[2])), zip(û, v̂)) @test a == b == c == d end