Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessagePack serialization option #88

Open
Roee-87 opened this issue Nov 7, 2023 · 1 comment
Open

MessagePack serialization option #88

Roee-87 opened this issue Nov 7, 2023 · 1 comment

Comments

@Roee-87
Copy link

Roee-87 commented Nov 7, 2023 •
edited
Loading

Would you be open to adding a feature allowing for the option of serializing a GradientBooster struct using MessagePack instead of JSON?
If so, I'd be happy to submit a PR to enable it.
@jinlow
Copy link
Owner

jinlow commented Nov 8, 2023 •
edited
Loading

Absolutely, PR welcome!
My only request (and maybe this is what you are alluding to), would be that the MesssagePack support be optional, and the user could toggle as a feature dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jinlow @Roee-87