Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent normal losses #12

Open
cr333 opened this issue Sep 4, 2023 · 0 comments
Open

Inconsistent normal losses #12

cr333 opened this issue Sep 4, 2023 · 0 comments

Comments

@cr333
Copy link

cr333 commented Sep 4, 2023

I wanted to let you know about an inconsistency in the code.

The code seems to contain two normal losses:

  1. get_normal_l1_loss, which actually computes an angular loss, as pointed out in Equation 12 of your paper. This name seems confusing, as it does not compute the L1 normal loss.
  2. get_normal_angular_loss, which actually computes the truncated scaled angle.

However, the loss computation in forward uses loss 1 above twice (see this line), weighted by (self.normal_weight + self.angular_weight), and loss 2 above is not used at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant