Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in popup window is not transferred to main window #9

Open
Anaphory opened this issue Aug 4, 2018 · 3 comments
Open

Search in popup window is not transferred to main window #9

Anaphory opened this issue Aug 4, 2018 · 3 comments

Comments

@Anaphory
Copy link

Anaphory commented Aug 4, 2018

Before, and after installing and running ngrok as described in the README.md and adding the address to public/bibnet_chrome_extension_testing/content_script.js, searching for terms in the main WC? window opens a popup window with the google scholar results, but does not show the results back in the main window.

Do I need to tell the system somehow that it's in testing mode? The extension comes from the chromium web store, which I don't assume knows anything about my local changes?

@jimmytidey
Copy link
Owner

It sounds as though the popup is being prevented from sending back the data, likely because the ngrok proxy isn't working. You need to get the inspector out in the popped-up google scholar window and see what it's reporting when it tries to the request to your ngrok proxy.

Is it sending it to the right address? Is it getting blocked because it's not HTTPS?

@Anaphory
Copy link
Author

Anaphory commented Aug 5, 2018

I figured it out, it was some issue with the current versions of meteor client-side. (Underscore not loaded properly? Babel version? I need to undo some changes like

-               _.each(bibnet.cookies, function(cookie){
+               bibnet.cookies.forEach(function(cookie){

in server/bibnet.js (the correct solution is to explicitly require underscore, and not to use these methods, I think) and test again, then you'll get a pull request.

@Anaphory
Copy link
Author

Anaphory commented Aug 5, 2018

Ah, no, the solution to this was to install the local version of the add-on, not the one from the chrome store; instructions for that should also go into the readme under the localhost instructions:

Open the ‘extensions’ settings; switch on ‘Developer mode’ (switch on the top-right), ‘Load unpacked’ from bibnet/public/bibnet_chrome_extension_testing.

Anaphory pushed a commit to Anaphory/bibnet-google-scholar-scraper that referenced this issue Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants