Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querystring templatetag shadows built-in Django 5.1 templatetag with same name #976

Open
federicobond opened this issue Nov 29, 2024 · 0 comments

Comments

@federicobond
Copy link
Contributor

Since version 5.1, Django includes a built-in querystring templatetag. However, when loading the django_tables2 templatetag library, the built-in tag is shadowed. Since these templatetags are incompatible, it leads to some confusion, which will only grow as usage of the built-in querystring becomes more widespread.

So far, I have considered the following alternatives:

  1. Moving the querystring templatetag to a separate library (for example django_tables2_utils).
  2. Renaming the querystring templatetag to something else, like query_replace or querystring_replace
  3. A combination of (1) and (2)

Unfortunately, none of these alternatives is backward-compatible if the user has copied/modified the default table templates for their project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant