Revert "grub-efi: Remove $cmdpath from configuration for for grub-mki…

[yizhao1]

…mage"

This reverts commit 5fcb2f0.

$cmdpath is an important grub environment variable. Remove it will cause
the boot failure.

Signed-off-by: Yi Zhao [email protected]

[jiazhang0]

Please help to fix another issue here:

search.file (\$cmdpath)${GRUB_PREFIX_DIR}/grub.cfg

According to https://www.gnu.org/software/grub/manual/grub/html_node/search.html, the default variable used to store the found device is 'root'. In addition, the syntax of search.file command doesn't support the second parameter.

[yizhao1]

On 11/25/21 5:28 PM, Jia Zhang wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In meta-efi-secure-boot/recipes-bsp/grub/grub-efi-efi-secure-boot.inc <https://urldefense.com/v3/__https://github.com/jiazhang0/meta-secure-core/pull/233*discussion_r756712257__;Iw!!AjveYdw8EvQ!Mp5oZuUlyFfXUTdkCi9UZ4PsDBxP5Hpgqx-U4VrX3rxC0LMjKnR_XbGyKe8HNwG-1Q$>: > @@ -89,7 +89,7 @@ EOF > ${WORKDIR}/cfg fi cat<<EOF>>${WORKDIR}/cfg -search.file ${GRUB_PREFIX_DIR}/grub.cfg root +search.file (\$cmdpath)${GRUB_PREFIX_DIR}/grub.cfg root Please help to fix another issue here: |search.file (\$cmdpath)${GRUB_PREFIX_DIR}/grub.cfg | According to https://www.gnu.org/software/grub/manual/grub/html_node/search.html <https://urldefense.com/v3/__https://www.gnu.org/software/grub/manual/grub/html_node/search.html__;!!AjveYdw8EvQ!Mp5oZuUlyFfXUTdkCi9UZ4PsDBxP5Hpgqx-U4VrX3rxC0LMjKnR_XbGyKe9NH5Qntw$>, the default variable used to store the found device is 'root'. In addition, the syntax of search.file command doesn't't support the second parameter.

OK. I will check it. //Yi

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/jiazhang0/meta-secure-core/pull/233*pullrequestreview-815745436__;Iw!!AjveYdw8EvQ!Mp5oZuUlyFfXUTdkCi9UZ4PsDBxP5Hpgqx-U4VrX3rxC0LMjKnR_XbGyKe8q0VCm8g$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AJEALVZ5PVRRUN27NUJXMJTUNX6TFANCNFSM5IX7V33Q__;!!AjveYdw8EvQ!Mp5oZuUlyFfXUTdkCi9UZ4PsDBxP5Hpgqx-U4VrX3rxC0LMjKnR_XbGyKe-RHFQmVQ$>. Triage notifications on the go with GitHub Mobile for iOS <https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!AjveYdw8EvQ!Mp5oZuUlyFfXUTdkCi9UZ4PsDBxP5Hpgqx-U4VrX3rxC0LMjKnR_XbGyKe9XHetCmA$> or Android <https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!AjveYdw8EvQ!Mp5oZuUlyFfXUTdkCi9UZ4PsDBxP5Hpgqx-U4VrX3rxC0LMjKnR_XbGyKe9NxNs6HA$>.

[jiazhang0]

@yizhao1 Is there any feedback about this?

[phatina]

…mage"

This reverts commit 5fcb2f0.

$cmdpath is an important grub environment variable. Remove it will cause the boot failure.

Signed-off-by: Yi Zhao [email protected]

With this search.file (\$cmdpath)${GRUB_PREFIX_DIR}/grub.cfg root, I observed boot device duplicity in this path. I could not boot my board in this configuration. Will get to it soon to provide you with full logs.