From 26ac87adfed2c65d6338501819247bde717c58c2 Mon Sep 17 00:00:00 2001 From: Quentin Date: Thu, 26 Dec 2024 21:43:55 +0100 Subject: [PATCH 1/4] Typo: have=>has --- .../src/main/webapp/app/auth/account.service.spec.ts.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache b/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache index ebe82d39426..33b353f568c 100644 --- a/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache +++ b/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache @@ -70,7 +70,7 @@ describe('Account Service', () => { httpMock.expectOne({ method: 'GET' }).flush('404 error', { status: 404, statusText: 'Not Found' }); }); - it('should call /account only once if last call have not returned', () => { + it('should call /account only once if last call has not returned', () => { service.identity().subscribe(); service.identity().subscribe(); From 590089065be3bcfc12d840afe33256b75636dd94 Mon Sep 17 00:00:00 2001 From: Quentin Date: Thu, 26 Dec 2024 21:44:40 +0100 Subject: [PATCH 2/4] Typo: not=>no --- .../src/main/webapp/app/auth/account.service.spec.ts.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache b/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache index 33b353f568c..2390e76d96b 100644 --- a/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache +++ b/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache @@ -101,7 +101,7 @@ describe('Account Service', () => { expect(hasAuthority).toBe(false); }); - it('should return false if user is logged and has not authority', () => { + it('should return false if user is logged and has no authority', () => { service.authenticate(accountWithAuthorities([Authority.USER])); const hasAuthority = service.hasAnyAuthority(Authority.ADMIN); From 67543504feb4a99b4c0bb35cabdffa287148189b Mon Sep 17 00:00:00 2001 From: Quentin Date: Thu, 26 Dec 2024 21:45:01 +0100 Subject: [PATCH 3/4] Typo: not=>no --- .../src/main/webapp/app/auth/account.service.spec.ts.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache b/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache index 2390e76d96b..be66d5b6f7c 100644 --- a/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache +++ b/src/main/resources/generator/client/angular/security/jwt/src/main/webapp/app/auth/account.service.spec.ts.mustache @@ -124,7 +124,7 @@ describe('Account Service', () => { expect(hasAuthority).toBeFalsy(); }); - it('should return false if user is logged and has not authority', () => { + it('should return false if user is logged and has no authority', () => { service.authenticate(accountWithAuthorities([Authority.USER])); const hasAuthority = service.hasAnyAuthority([Authority.ADMIN]); From ac857b0ffe30722ea0d70a7fc991b3845cd3356e Mon Sep 17 00:00:00 2001 From: Quentin Date: Thu, 26 Dec 2024 21:55:07 +0100 Subject: [PATCH 4/4] Typo: feedbacks=>feedback --- documentation/hexagonal-architecture.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/hexagonal-architecture.md b/documentation/hexagonal-architecture.md index 6e12f4dcbbd..59642ff412a 100644 --- a/documentation/hexagonal-architecture.md +++ b/documentation/hexagonal-architecture.md @@ -41,7 +41,7 @@ The very clear separation of concern enforced by the architecture eases automati ### Shorten feedback loops -In software development if you want to go faster (like really faster) you'll have to go for short feedbacks loops. If you have a button that can tell you in a few seconds that your solution is still behaving as intended you'll be way faster than checking that by hand after any update (in fact, you won't check by hand that after any update...). +In software development if you want to go faster (like really faster) you'll have to go for short feedback loops. If you have a button that can tell you in a few seconds that your solution is still behaving as intended you'll be way faster than checking that by hand after any update (in fact, you won't check by hand that after any update...). Let's be honest here: hexagonal architecture won't help for the fastest feedback loops which are pair feedback in [pair](https://en.wikipedia.org/wiki/Pair_programming) or [mob programming](https://en.wikipedia.org/wiki/Mob_programming).