Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ColumnTypeEquivalence and mapLiterals #47

Closed
brendanator opened this issue Jul 13, 2015 · 1 comment
Closed

Refactor ColumnTypeEquivalence and mapLiterals #47

brendanator opened this issue Jul 13, 2015 · 1 comment

Comments

@brendanator
Copy link
Contributor

This is probably the flakiest part of sqlest and definitely still has a bug in it: using a Setter with a non-Option column and a Option value will throw a ClassCastException when trying to write to the database

Possible approaches:

  1. Move the logic of mapLiterals into ColumnTypeEquivalence
  2. Make ColumnTypeEquivalence instantiation a macro to avoid illegal comparisons at compile time
  3. Apply mapLiterals in columnSetterPair

If 2) is implemented it may be possible to fix #43 at the same time

@brendanator
Copy link
Contributor Author

Fixed by 626c624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant