Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(short feature description) #132

Closed
tomjfrog opened this issue Feb 7, 2024 · 1 comment
Closed

(short feature description) #132

tomjfrog opened this issue Feb 7, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@tomjfrog
Copy link

tomjfrog commented Feb 7, 2024

Is your feature request related to a problem? Please describe.

The feature request is not related to an operational problem with the tool. It's a documentation enhancement.

Describe the solution you'd like to see

There is an undocumented, and quite useful, input to the Action for the OIDC integration. In the code, it's clear we can take in an input parameter called oidc-audience. I'd like to see this documented. This is an important configuration option that can make implementing the OIDC configuration in the JFrog Platform much easier for users.

      - name: Install JFrog CLI
        uses: jfrog/setup-jfrog-cli@v3
        env:
          JF_URL: ${{ vars.JF_URL }}
        with:
          oidc-provider-name: ${{ env.JF_OIDC_PROVIDER_NAME }}
          oidc-audience: ${{ env.OIDC_AUDIENCE }}

Describe alternatives you've considered

No response

Additional context

No response

@tomjfrog tomjfrog added the feature request New feature or request label Feb 7, 2024
@yahavi
Copy link
Member

yahavi commented Feb 16, 2024

@tomjfrog
The oidc-audience field is documented inside the collapsed Connecting to JFrog using OIDC (OpenID Connect)
section.

See step 3 in Workflow configuration.

@yahavi yahavi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants