-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Xray Source Control Service #2141
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
had a problem deploying
to
frogbot
September 3, 2023 13:40
— with
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
September 4, 2023 07:34
— with
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
September 4, 2023 07:57
— with
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
September 5, 2023 11:10
— with
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
September 6, 2023 08:54
— with
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
September 6, 2023 15:45
— with
GitHub Actions
Failure
3 tasks
EyalDelarea
had a problem deploying
to
frogbot
September 7, 2023 09:28
— with
GitHub Actions
Failure
EyalDelarea
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 7, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 7, 2023
EyalDelarea
had a problem deploying
to
frogbot
September 8, 2023 13:05
— with
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
September 8, 2023 13:13
— with
GitHub Actions
Failure
sverdlov93
reviewed
Sep 9, 2023
xray_test.go
Outdated
Comment on lines
152
to
155
if !isXsc { | ||
initXrayTest(t, scangraph.GraphScanMinXrayVersion) | ||
} | ||
initXrayTest(t, scangraph.GraphScanMinXrayVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
EyalDelarea
had a problem deploying
to
frogbot
September 10, 2023 07:45
— with
GitHub Actions
Failure
EyalDelarea
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 10, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 10, 2023
EyalDelarea
had a problem deploying
to
frogbot
September 10, 2023 12:30
— with
GitHub Actions
Failure
XSC shouldn't be tested via the CLI at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.Adding XSC support to JFrog Cli and it's components
jf-audit
command is implemented to work with XSC, sending extra GitInfoContext object to allow linking scan data to repositories./xsc
suffix.How to use
No action from the user is needed, as this is optional.
If the server has XSC, it will query it.
In order to use the new functionality of linking scan information to repository, need to set the XscGitinfoContext object when calling
audit
command:Depends on
JFrog client go jfrog/jfrog-client-go#811
JFrog cli-core jfrog/jfrog-cli-core#896