Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New --module option added to the build-add-dependencies command #2081

Merged
merged 31 commits into from
Jul 31, 2023

Conversation

sarao1310
Copy link
Contributor

@sarao1310 sarao1310 commented Jul 17, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sarao1310 sarao1310 requested a review from eyalbe4 July 17, 2023 10:06
@sarao1310 sarao1310 changed the title Add module flag to bad Add --module flag to build add dependency Jul 17, 2023
@sarao1310 sarao1310 added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Jul 17, 2023
@sarao1310 sarao1310 changed the title Add --module flag to build add dependency Add --module flag to build add dependency command Jul 17, 2023
@sarao1310 sarao1310 added improvement Automatically generated release notes and removed new feature Automatically generated release notes labels Jul 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 17, 2023
@sarao1310 sarao1310 removed the request for review from eyalbe4 July 17, 2023 12:29
@sarao1310 sarao1310 temporarily deployed to frogbot July 17, 2023 12:33 — with GitHub Actions Inactive
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 17, 2023
@github-actions
Copy link
Contributor

@sarao1310 sarao1310 requested a review from eyalbe4 July 17, 2023 19:00
@eyalbe4 eyalbe4 changed the title Add --module flag to build add dependency command New --module option added to the build-add-dependencies command Jul 18, 2023
@eyalbe4 eyalbe4 changed the title New --module option added to the build-add-dependencies command New --module option added to the build-add-dependencies command Jul 18, 2023
@sarao1310 sarao1310 removed the request for review from eyalbe4 July 18, 2023 13:11
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@sarao1310 sarao1310 requested a review from eyalbe4 July 23, 2023 08:29
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@eyalbe4 eyalbe4 self-requested a review July 26, 2023 12:49
@@ -893,6 +893,7 @@ By default, the command collects the files from the local file system. If you'd
| --recursive | \[Default: true\]<br><br>When false, artifacts inside sub-folders in Artifactory will not be affected. |
| --regexp | \[Optional: false\]<br><br>\[Default: false\] Set to true to use a regular expression instead of wildcards expression to collect files to be added to the build info.This option is not supported when --from-rt is set to true. |
| --dry-run | \[Default: false\]<br><br>Set to true to only get a summery of the dependencies that will be added to the build info. |
| --module | \[Optional\]<br><br>Optional module name for the build-info. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional module name for the build-info.
-->
Optional module name in the build-info for adding the depedency

(let's ensure to use the same phrasing for the embedded CLI help as well).

buildinfo_test.go Outdated Show resolved Hide resolved
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@sarao1310 sarao1310 added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@sarao1310 sarao1310 merged commit 16730c5 into jfrog:dev Jul 31, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants