Integration tests for Advanced Security #2037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orto17
commented
Jun 22, 2023
orto17
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
changed the title
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
Jul 20, 2023
xray_test.go
Outdated
Comment on lines
560
to
562
| for _, vuln := range results.Vulnerabilities { | ||
| assert.NotEmpty(t, vuln.Applicable) | ||
| } |
There was a problem hiding this comment.
Wouldn't be better to move this loop into the above if statement?
xray_test.go
Outdated
Comment on lines
167
to
177
| //func TestXrayAuditJasSimpleJson(t *testing.T) { | ||
| // output := testXrayAuditJas(t, string(utils.SimpleJson), "jas") | ||
| // verifySimpleJsonScanResults(t, output, 0, 0, 1, 1) | ||
| // verifySimpleJsonJasResults(t, output, 3, 2) | ||
| //} | ||
| // | ||
| //func TestXrayAuditJasNoViolationsSimpleJson(t *testing.T) { | ||
| // output := testXrayAuditJas(t, string(utils.SimpleJson), "npm") | ||
| // verifySimpleJsonScanResults(t, output, 0, 0, 1, 1) | ||
| // verifySimpleJsonJasResults(t, output, 0, 0) | ||
| //} |
There was a problem hiding this comment.
Let's uncomment the above tests.
…t' into analyzer-manager-intergation-test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
…t' into analyzer-manager-intergation-test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.