[ansible/artifactory] Use fetch and lookup('ini') to get the version
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution ! will test this internally and if it looks good , we plan it for next patch release |
|
No need to use shell/fetch/lookup and all those things. Artifactory already has api endpoint https://jfrog.com/help/r/jfrog-rest-apis/version-and-add-ons-information |
chukka
approved these changes
Mar 1, 2024
chukka
added a commit
that referenced
this pull request
Mar 1, 2024
* #365 Use `fetch` and `lookup('ini')` to get the version (#369) * [ansible] JFrog Platform 10.17.1 release --------- Co-authored-by: David Lundgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ansible/artifactory])What this PR does / why we need it:
Changes the way that the Artifactory product version is obtained.
Which issue this PR fixes: fixes #365
Special notes for your reviewer:
ansible.builtin.slurpcould also be used if we want to not rely on a temporary file, but it requires some filtering within Ansible to the same data.