[ansible/artifactory] Assert that database username and password are defined. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bas Meijer <[email protected]>
bbaassssiiee
force-pushed
the
bugfix/311
branch
from
374f742 to
43ab561
Compare
Logeshwarsn
reviewed
Oct 9, 2023
Ansible/ansible_collections/jfrog/platform/roles/postgres/tasks/install.yml
Outdated
Show resolved
Hide resolved
|
@bbaassssiiee Could you please address the comment ? |
chukka
pushed a commit
that referenced
this pull request
Oct 26, 2023
…defined. (#336) * Assert that database username and password are defined. Signed-off-by: Bas Meijer <[email protected]> * Assertion at the start of the postgres role. --------- Signed-off-by: Bas Meijer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ansible/artifactory])What this PR does / why we need it:
The looping in the creation tasks for user, database and privileges in the postgres role did not fail on undefined values. Input validation was missing, and the logging of item=None is not so useful.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):fixes #311
Special notes for your reviewer: