fix clippy lints #78
Merged
fix clippy lints #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should I update the MSRV? |
|
@jfrimmel using |
|
I think it would be fine to raise the MSRV, as it is promised nowhere as of now. So: go for it 😉 |
|
Ah, it looks like I've screwed up the CI configuration. I've pulled in the latest CI changes. This allows me to run the missing workflows. |
|
hey I updated the MSRV both in |
|
Thank you very much! |
jfrimmel
added a commit
that referenced
this pull request
Sep 23, 2024
This is possible thanks to the raised MSRV in #78. Many dependencies are not updated, though, as the MSRV is still rather old and, unfortunately, not all dependencies declare a MSRV, thus an automatic `cargo update` is not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nothing major, just ran
cargo clippy fix, then applied non-automatic fixes manually