Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] Text components that appear next to one another have excessively large margins between them #19

Open
jfmcquade opened this issue Sep 16, 2022 · 0 comments

Comments

@jfmcquade
Copy link
Owner

jfmcquade commented Sep 16, 2022

For some reason it seems that most empty components are hidden, but not the last one in any sequence of empty components. I'm merging this anyway since also like this it's an improvement

image

Originally posted by @EsmeeIDEMS in #15 (review)

I believe these elements are displaying correctly, it's just a feature of the debug overlays that they attach to the element inside its margins. So I think the real issue is that there is too much whitespace between separate text elements that appear one after the other. This whitespace is made up of the sum of the top margin on each <plh-template-component> element and the margins around its nested child <p> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant