Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tmp directory tests are failing on macos #259

Open
jfischoff opened this issue Jun 10, 2020 · 6 comments
Open

Tmp directory tests are failing on macos #259

jfischoff opened this issue Jun 10, 2020 · 6 comments
Labels
internal No need to bump the version

Comments

@jfischoff
Copy link
Owner

No description provided.

@jfischoff jfischoff added the internal No need to bump the version label Jun 10, 2020
@dhess dhess mentioned this issue Mar 3, 2022
Closed
@dhess
Copy link

dhess commented Mar 3, 2022

Hi,

We've successfully deployed tmp-postgres in our test suite now, and it's working great, except on our x86-64 Macs, where our tests will occasionally fail for strange reasons. If we re-run the failed job, it nearly always succeeds the second time.

The failure modes differ. Sometimes the failure occurs because the server refuses a connection, sometimes the connection times out, and sometimes an insert will fail because PostgreSQL complains that the database doesn't exist, despite our migration script having run and set up the database prior to the insert failing.

For compatibility with Sqitch, which we're using for migrations, we run the server on localhost:5423 and connect via TCP loopback. We're making use of tmp-postgress database caching per your helpful blog post, though we're not yet using every trick in your arsenal, mainly just the initial approach you describe in that post. We also disable parallelism in our tests in order to achieve maximum isolation, and to keep the test harness relatively simple.

We've yet to see any of these issues on our aarch64 Macs, nor our x86-64 Linux machines.

When I searched the tracker for "macos", I saw this issue. Can you provide some detail on what sorts of failures you're seeing? I'm curious if it has anything to do with our issues.

@jfischoff
Copy link
Owner Author

Sorry, this was a note to myself to update a test after a change was made to support the TMP environment variable (#256), I'm pretty sure. I don't think there was anything actually wrong.

The main issue that I've seen, that I have struggled to understand, is this one: #251.

The failure modes differ. Sometimes the failure occurs because the server refuses a connection, sometimes the connection times out, and sometimes an insert will fail because PostgreSQL complains that the database doesn't exist, despite our migration script having run and set up the database prior to the insert failing.

Huh this actually quite confusing.

Something to look out for is the postgres might not be shutting down correctly. This will result in it running out of semaphores when it starts. However typically, the error message will say this specifically.

@dhess
Copy link

dhess commented Mar 4, 2022

I've just had a failure on an Apple Silicon Mac, as well, so this isn't Intel-specific, which is actually comforting. :)

@jfischoff
Copy link
Owner Author

jfischoff commented Mar 4, 2022 via email

@dhess
Copy link

dhess commented Mar 4, 2022

I have a guess at what might be going on. Let me look into that and if I can't get to the bottom of it, I'll post the gists of the errors. Thanks for your help!

@jfischoff
Copy link
Owner Author

jfischoff commented Mar 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal No need to bump the version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhess @jfischoff