-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: badge wasn't showing the latest job run from master #633
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maelvls
Suggest also updating the release-process to instruct the releaser to check the status of the tests and the govulncheck on master branch before creating the tag.
Either here or in a followup PR.
/approve
/lgtm
I like this idea. I'll add that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme: add govulncheck and checking github action to release process Ignore this.
Done, PTAL @wallrj |
```bash | ||
go install golang.org/x/vuln/cmd/govulncheck@latest | ||
govulncheck -v ./... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The govulncheck action is broken
https://github.com/jetstack/jetstack-secure/actions/workflows/govulncheck.yaml
[govulncheck: pkg/client/client_venconn.go#L14](https://github.com/jetstack/jetstack-secure/commit/2d13638d7f1a7d149d625ce1127fb95c4a5d1809#annotation_29287405002)
github.com/jetstack/[email protected]: invalid version: git ls-remote -q origin in /home/runner/go/pkg/mod/cache/vcs/e1445deb79b4ca14ee954e0f79f4034748b368f02a81510920a656b6ce2c6380: exit status 128:
So until we fix that, we have to run govulncheck manually before releasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can fix that in another PR:
The badge wasn't showing the latest job run from master. It was green because the workflow was green due to the pull requests.
Before:
After:
The badge is now grayed out becuase the "tests" workflow doesn't currently run on the master branch due to probable copy-paste issue (it was set to trigger on the main branch, but this project doesn't have a main branch).
Fixes #632