Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: dependency-check-ant includes slf4j impl #879

Open
asoftwareguy opened this issue Sep 13, 2017 · 3 comments
Open

Question: dependency-check-ant includes slf4j impl #879

asoftwareguy opened this issue Sep 13, 2017 · 3 comments

Comments

@asoftwareguy
Copy link

Why does the JAR come packaged with an implementation instead of relying on the API? When deployed with other projects, it causes the multiple slf4j bindings issue.

@jeremylong
Copy link
Owner

Dependency-check has an instance of slf4j in its lib directory as slf4j is not used by Ant. I'm double checking with @colezlaw - but if memory serves implementing a StaticLoggerBinder allows a library that uses SLF4j (in this case dependency-check) to route log messages to Ant.

@asoftwareguy
Copy link
Author

Thanks for checking. When I am integrating, the problem I am ending up with is the following: https://www.slf4j.org/codes.html#multiple_bindings

@jeremylong
Copy link
Owner

Newer versions of slf4j appear to support the Java extensions mechanism to load services. We need to investigate changing our binding to use this instead of the static binder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants