Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: (regression of #6695) CVE-2022-21704 still gets flagged on a Node.js dependency, #6869

Closed
volkert-fastned opened this issue Jul 23, 2024 · 3 comments
Labels
FP Report maven changes to the maven plugin

Comments

@volkert-fastned
Copy link
Contributor

Package URl

pkg:maven/org.apache.logging.log4j/[email protected]

CPE

cpe:2.3:a:log4js_project:log4js:2.23.1:*:*:*:*:*:*:*

CVE

CVE-2022-21704

ODC Integration

{"label"=>"Gradle Plugin"}

ODC Version

10.0.3

Description

As I stated in this comment, the previous regression didn't work.

In this other comment, I shared required change to make it work.

TL;DR: the CPE section in the suppression has to be changed as follows:

<cpe>cpe:/a:log4js_project:log4js</cpe>
Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>org.apache.logging.log4j</groupId>
   <artifactId>log4j-slf4j2-impl</artifactId>
   <version>2.23.1</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #6869
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/org\.apache\.logging\.log4j/log4j-slf4j2-impl@.*$</packageUrl>
   <cpe>cpe:/a:log4js_project:log4js</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/10059660424

@github-actions github-actions bot added the maven changes to the maven plugin label Jul 23, 2024
@volkert-fastned
Copy link
Contributor Author

This yet another example of a FP as result of a platform/language mismatch. @OrangeDog FYI

aikebah added a commit that referenced this issue Aug 24, 2024
Fixup the wrongly added suppression as per comment
b2052fb#r142470093
and issue #6869
@aikebah
Copy link
Collaborator

aikebah commented Aug 24, 2024

The original suppression from #6695 has been corrected and FP suppression automation has published the updated hosted suppressions file

@aikebah aikebah closed this as completed Aug 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FP Report maven changes to the maven plugin
Projects
None yet
Development

No branches or pull requests

2 participants