Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] suppression based on confidence level #670

Open
piyushml20 opened this issue Feb 22, 2017 · 5 comments
Open

[Feature Request] suppression based on confidence level #670

piyushml20 opened this issue Feb 22, 2017 · 5 comments

Comments

@piyushml20
Copy link

Hello,

Currently, we can suppress findings based on CVSS score, CPE and others but not based on confidence level which in turn is based on evidence collection. This will be a good to have feature.

@jeremylong
Copy link
Owner

The problem with implementing this is that it would create false negatives. I understand that at times the scan results can be a little noisy; however, in my experience taking a few minutes to create a suppression file is a much better route.

I'll put this on the enhancement list; but when this gets built we need to write a bug warning message in the output (and possibly report) indicating that a configuration was set that can generate false negatives.

@piyushml20
Copy link
Author

piyushml20 commented Nov 24, 2017

version 3.0.2 has introduced new columns in csv file format (source, GAV, CPE confidence, evidence count) but those are not populated.

Additionally, Severity column value is ending up in Source column and CVSS2 column is ending up in Severity column.

@piyushml20
Copy link
Author

Sorry, this was issue on my end. Report is getting generated properly.

@HowardMilano
Copy link

If a project has a limited number of dependencies, creating a suppression file can indeed take mere minutes. However, if you have a larger project, the result file can be huge (64M in our case) and it takes hours or days to create a suppression file. All the low and medium confidence issues I looked at are false positives, the high confidence issues are marginally related but basically also false positives, while the highest confidence issues are worth pursuing. Filtering on confidence is a huge gain for larger projects.

@wilx
Copy link
Contributor

wilx commented Sep 22, 2020

With issues like #2794, using filter on confidence level could be a nice workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants