Add msbuild executable name

[sfenu]

From direct testing and from Msbuild plugin page (https://plugins.jenkins.io/msbuild):
"Usage
To use this plugin, specify the location directory of MSBuild.exe on Jenkin's configuration page."

The command will work if full path to executable is included in the msbuild configuration, but then in that case a msbuild step in a freestyle job will not work.

[Jasonf1977]

It works fine as is, if your tool path is contains msbuild.exe already. Mine did so this mod would be wrong for me. I think this is a config issue not a problem with the example.

[sfenu]

Yes, but if you include msbuild.exe in your tool path and then you use a msbuild step in a freestyle (not pipeline) job, the msbuild step in that freestyle job will not work. That means that for the example to work, you need a tool configuration which will create issues in freestyle jobs that use msbuild steps. That means that the example is wrong, in my opinion.

[Jasonf1977]

I am new to pipelines but on my install including the exe in the path allows both freestyle and pipeline to work. Maybe I’m special.

…

On Aug 27, 2018, at 3:04 AM, sfenu ***@***.***> wrote: Yes, but if you include msbuild.exe in your tool path and then you use a msbuild step in a freestyle (not pipeline) job, the msbuild step in that freestyle job will not work. That means that for the example to work, you need a tool configuration which will create issues in freestyle jobs that use msbuild steps. That means that the example is wrong, in my opinion. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[pvkamath]

Not sure how the people using msbuild.exe in their paths are getting this to work. (see screenshot from Jenkins Build 2.138.X). How are your msbuild configs accepting the paths including msbuild.exe when Jenkins specifically expects a directory ?

I ran into this problem from Day 1 when I tried to use the syntax referred to in the tutorial. Note that my MSBuild installation does not have msbuild.exe at the end because it throws the error shown in the screenshot when I try to add it. And using the name of the installation does not work. Wasted more than an hour trying to get it to work till I tried the fix mentioned in this PR and it worked (Didn't see this PR till now, I arrived at my solution using the "Try This, Try That" approach).

So, the solution should be

• Pipeline must deduce the name of the msbuild exe i.e. MSBuild.exe. This is the right approach because using the UI approach, one needs to only select the MSBuild install from the Global Tool Configuration, the name of the solution file and the build parameters.
• The string "msbuild.exe" should be appended to the "${tool MSBuild}" part in the tutorial i.e. this PR must be merged into master.