Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use truncated strings from checks api #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrginglymus
Copy link
Contributor

Consumer implementation of jenkinsci/checks-api-plugin#68

Is there a way we can set a constraint on the version of github-checks-plugin without requiring it to be installed, such that we don't have to go through a gradual deprecation process of the old logic?

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane, I wrote a test for this initially but I couldn't manage to make windows CI pass and I think I ended up deleting the test

@mrginglymus mrginglymus marked this pull request as ready for review January 30, 2021 12:45
@mrginglymus mrginglymus requested a review from timja January 30, 2021 12:46
@timja
Copy link
Member

timja commented Jan 30, 2021

Is there a way we can set a constraint on the version of github-checks-plugin without requiring it to be installed, such that we don't have to go through a gradual deprecation process of the old logic?

Short of putting it in the release notes, no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants