[JENKINS-74806] Extract inline script bpp.jelly BuildPipelineView/bpp.jelly
#150
+64
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2024
basil
reviewed
Nov 8, 2024
src/main/webapp/js/build-pipeline.js
Outdated
| jQuery("#pipelines").trigger("show-status-" + this); | ||
| jQuery("table.pipelines").trigger("show-status-" + this); |
There was a problem hiding this comment.
This id vs class issue looks like a separate pre-existing issue that we can split to a new PR.
6 tasks
...s/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
Show resolved
Hide resolved
...main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
Outdated
Show resolved
Hide resolved
...s/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/build-pipeline-init.js
Outdated
Show resolved
Hide resolved
yaroslavafenkin
approved these changes
Nov 25, 2024
...main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-74806
This PR extracts non CSP compliant code in the jelly file.
Requires #158 to see cards update dynamically.
Testing done
This was thoroughly tested and the pipeline is working the same as before the extractions.
BEFORE CHANGES
AFTER CHANGES
Submitter checklist
\