Some Integration tests are failing

[sridamul]

Plugin Modernizer version

1145.v9716249cc13c

What Operating System are you using

Gitpod and Windows

Reproduction steps

mvn clean install

(Ensure to start the Docker engine, else IT will be skipped)

Here is the log files in Windows and Gitpod environment.

Expected Results

All test cases should be passing

[jonesbusy]

It's working on CI, maybe specific to this environment ?

[sridamul]

I think they are skipped in the CI https://ci.jenkins.io/job/Tools/job/plugin-modernizer-tool/job/main/435/testReport/

[jonesbusy]

They are not skipped on Linux https://ci.jenkins.io/job/Tools/job/plugin-modernizer-tool/job/main/435/testReport/io.jenkins.tools.pluginmodernizer.cli/CommandLineITCase/

I'm not sure why windows is not able to detect the docker installation

[jonesbusy]

Please check the logs of the maven invokation.

For example 'testVersion.txt'

Logs given here are not giving details about failre (only assertion errors)

[jonesbusy]

Any update ? Can you provide logs ?

[sridamul]

testBuildMetadata-empty.txt

Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=2
[INFO] Scanning for projects...
[WARNING] The requested profile "consume-incrementals" could not be activated because it does not exist.
[WARNING] The requested profile "might-produce-incrementals" could not be activated because it does not exist.
[INFO] 
[INFO] ---------< io.jenkins.plugin-modernizer:plugin-modernizer-it >----------
[INFO] Building plugin-modernizer-it 999999-SNAPSHOT
[INFO]   from pom-it.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ plugin-modernizer-it ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 2 resources from src/main/resources to target/classes
[INFO] 
[INFO] --- compiler:3.13.0:compile (default-compile) @ plugin-modernizer-it ---
[INFO] Nothing to compile - all classes are up to date.
[INFO] 
[INFO] --- resources:3.3.1:testResources (default-testResources) @ plugin-modernizer-it ---
[INFO] Not copying test resources
[INFO] 
[INFO] --- compiler:3.13.0:testCompile (default-testCompile) @ plugin-modernizer-it ---
[INFO] Not compiling test sources
[INFO] 
[INFO] --- surefire:3.2.5:test (default-test) @ plugin-modernizer-it ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- jar:3.4.1:jar (default-jar) @ plugin-modernizer-it ---
[INFO] 
[INFO] --- exec:3.5.0:exec (exec) @ plugin-modernizer-it ---
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=2
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=2
Maven version detected: 3.9.9 
Connecting to GitHub using token... 
(6d6bc158) GitHub API request: GET http://localhost:41569/api/user 
Getting current user using token... 
Connected to GitHub as 0 <[email protected]> 
Using SSH private key for git operation: /tmp/junit-14276740048752504908/empty 
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=2
Maven version detected: 3.9.9 
Creating cache at /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli 
Plugins: [empty] 
Recipe: io.jenkins.tools.pluginmodernizer.FetchMetadata 
GitHub owner: fake-owner 
SSH private key: /tmp/junit-14276740048752504908/empty 
Update Center Url: http://localhost:41569/update-center.json 
Plugin versions Url: http://localhost:41569/plugin-versions.json 
Plugin Health Score Url: http://localhost:41569/scores 
Installation Stats Url: http://localhost:41569/jenkins-stats/svg/202406-plugins.csv 
Cache Path: /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli 
Maven Home: /workspace/plugin-modernizer-tool/plugin-modernizer-cli/target/apache-maven-3.9.9 
Maven Local Repository: /home/gitpod/.m2/repository 
Dry Run: false 
Maven rewrite plugin version: 5.47.3 
Cache entry not found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key plugin-versions 
Fetching data from: http://localhost:41569/plugin-versions.json 
[HttpClient-1-Worker-2] [160ms] Http2Connection(SocketTube(1)) For the record:jdk.internal.net.http.Http2Connection@44ae3457 
[HttpClient-1-Worker-2] [160ms] Http2Connection(SocketTube(1)) Decoder created: jdk.internal.net.http.hpack.Decoder@4b3af488 
[HttpClient-1-Worker-2] [161ms] Http2Connection(SocketTube(1)) Encoder created: jdk.internal.net.http.hpack.Encoder@4671f160 
[HttpClient-1-Worker-2] [166ms] Http2Connection(SocketTube(1)) decodeHeaders(jdk.internal.net.http.Stream$HeadersConsumer@578a9ecb) 
Fetched data from: http://localhost:41569/plugin-versions.json 
Writing JSON file to /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli/./plugin-versions 
Cache entry not found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key update-center 
Fetching data from: http://localhost:41569/update-center.json 
[HttpClient-2-Worker-2] [188ms] Http2Connection(SocketTube(2)) For the record:jdk.internal.net.http.Http2Connection@47a2abb8 
[HttpClient-2-Worker-2] [188ms] Http2Connection(SocketTube(2)) Decoder created: jdk.internal.net.http.hpack.Decoder@439d2794 
[HttpClient-2-Worker-2] [188ms] Http2Connection(SocketTube(2)) Encoder created: jdk.internal.net.http.hpack.Encoder@69fa183 
[HttpClient-2-Worker-0] [190ms] Http2Connection(SocketTube(2)) decodeHeaders(jdk.internal.net.http.Stream$HeadersConsumer@292f0dde) 
Fetched data from: http://localhost:41569/update-center.json 
Writing JSON file to /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli/./update-center 
Repository name: empty 
Cache entry found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key update-center 
Plugin empty latest version: 1 
Cache entry not found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key health-score 
Fetching data from: http://localhost:41569/scores 
[HttpClient-3-Worker-2] [200ms] Http2Connection(SocketTube(3)) For the record:jdk.internal.net.http.Http2Connection@5f404eb7 
[HttpClient-3-Worker-2] [200ms] Http2Connection(SocketTube(3)) Decoder created: jdk.internal.net.http.hpack.Decoder@5b7fd187 
[HttpClient-3-Worker-2] [200ms] Http2Connection(SocketTube(3)) Encoder created: jdk.internal.net.http.hpack.Encoder@1e7d448c 
[HttpClient-3-Worker-0] [201ms] Http2Connection(SocketTube(3)) decodeHeaders(jdk.internal.net.http.Stream$HeadersConsumer@28dd22b5) 
Fetched data from: http://localhost:41569/scores 
Writing JSON file to /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli/./health-score 
Plugin empty health score: 100.0 
Cache entry not found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key plugin-installation-stats 
Fetching data from: http://localhost:41569/jenkins-stats/svg/202406-plugins.csv 
[HttpClient-4-Worker-0] [207ms] Http2Connection(SocketTube(4)) For the record:jdk.internal.net.http.Http2Connection@4faa8228 
[HttpClient-4-Worker-0] [208ms] Http2Connection(SocketTube(4)) Decoder created: jdk.internal.net.http.hpack.Decoder@4b950f05 
[HttpClient-4-Worker-0] [208ms] Http2Connection(SocketTube(4)) Encoder created: jdk.internal.net.http.hpack.Encoder@e978813 
[HttpClient-4-Worker-0] [208ms] Http2Connection(SocketTube(4)) decodeHeaders(jdk.internal.net.http.Stream$HeadersConsumer@24730b78) 
Fetched data from: http://localhost:41569/jenkins-stats/svg/202406-plugins.csv 
Writing JSON file to /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli/./plugin-installation-stats 
Plugin empty installations: null 
Cache entry found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key update-center 
Is API plugin empty : false 
Cache entry found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path . and key update-center 
(6726cc69) GitHub API request: GET http://localhost:41569/api/repos/jenkinsci/empty 
Skipping fork for plugin empty as only metadata is required 
Skipping sync for plugin empty as only metadata is required 
(6c3659be) GitHub API request: GET http://localhost:41569/api/repos/jenkinsci/empty 
Fetch plugin code empty from null into directory empty... 
Fetching empty 
(522bf64e) GitHub API request: GET http://localhost:41569/api/repos/jenkinsci/empty 
Clone successfully from ssh://git@localhost:32773/srv/git/empty.git 
Fetched repository from ssh://git@localhost:32773/srv/git/empty.git 
Cache entry not found for cache /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli at path empty and key plugin-metadata 
Collecting metadata for plugin empty... Please be patient 
Validating POM for plugin: empty 
JDK home: /home/gitpod/.sdkman/candidates/java/17.0.13-tem 
Adding --add-opens for JDK 17+ 
Build failed with code: 1 
Done 
Failed to collect metadata for plugin empty. Will retry after a first compile using lowest JDK 
Verifying plugin without tests empty using with JDK 8 ... Please be patient 
Running [verify, -DskipTests, -Pquick-build, -Denforcer.skip=true] phase for plugin empty 
Running maven on directory /tmp/junit-914877572241814665/jenkins-plugin-modernizer-cli/empty/sources 
Validating POM for plugin: empty 
JDK home: /home/gitpod/.sdkman/candidates/java/8.0.432-tem 
Build failed with code: 1 
Plugin empty failed to compile with JDK 8. Skipping metadata collection after retry 
************* 
Plugin: empty 
Error: Build failed with code: 1 
Stacktrace:  
io.jenkins.tools.pluginmodernizer.core.model.PluginProcessingException: Build failed with code: 1
	at io.jenkins.tools.pluginmodernizer.core.model.Plugin.addError(Plugin.java:346)
	at io.jenkins.tools.pluginmodernizer.core.impl.MavenInvoker.handleInvocationResult(MavenInvoker.java:257)
	at io.jenkins.tools.pluginmodernizer.core.impl.MavenInvoker.invokeGoals(MavenInvoker.java:161)
	at io.jenkins.tools.pluginmodernizer.core.impl.MavenInvoker.invokeGoal(MavenInvoker.java:88)
	at io.jenkins.tools.pluginmodernizer.core.model.Plugin.verifyQuickBuild(Plugin.java:526)
	at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.collectMetadata(PluginModernizer.java:378)
	at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.process(PluginModernizer.java:234)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at io.jenkins.tools.pluginmodernizer.core.impl.PluginModernizer.start(PluginModernizer.java:167)
	at io.jenkins.tools.pluginmodernizer.cli.command.BuildMetadataCommand.call(BuildMetadataCommand.java:78)
	at io.jenkins.tools.pluginmodernizer.cli.command.BuildMetadataCommand.call(BuildMetadataCommand.java:18)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2045)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
	at picocli.CommandLine.execute(CommandLine.java:2174)
	at io.jenkins.tools.pluginmodernizer.cli.Main.main(Main.java:47)
************* 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.776 s
[INFO] Finished at: 2025-01-09T16:13:24Z
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "consume-incrementals" could not be activated because it does not exist.
[WARNING] The requested profile "might-produce-incrementals" could not be activated because it does not exist.

I am not sure why the empty-plugin is not built using JDK 21. Even though it is installed in the /.sdkman/candidates/java.
All other failing tests are also failing in build step.

(Attached the modernizer.log)
modernizer.log

[jonesbusy]

I need to log of the empty plugin (empty.log I think) build. The one that contains the maven invocation. This is the plugin modernizer log.

If you get this log I'm sure it will tell you what is happening and why maven fail to compile the empty plugin.